Add type checking for all JS library decorators #20110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
decoratore_type_check
branch
from
6117c26 to
b47b273
Compare
tlively
reviewed
Aug 24, 2023
sbc100
force-pushed
the
decoratore_type_check
branch
2 times, most recently
from
5a88fcf to
484c125
Compare
kripken
approved these changes
Aug 24, 2023
sbc100
force-pushed
the
decoratore_type_check
branch
3 times, most recently
from
ed95c3e to
148c886
Compare
sbc100
force-pushed
the
decoratore_type_check
branch
from
148c886 to
d7e699e
Compare
tlively
approved these changes
Aug 29, 2023
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 31, 2024
It looks like this mode was broken from the moment it as added back in PR emscripten-core#20110. However it went unnoticed since it was only being used with a single function: `__syscall_fadvise64`. Split out from emscripten-core#22820.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 31, 2024
It looks like this mode was broken from the moment it as added back in PR emscripten-core#20110. However it went unnoticed since it was only being used with a single function: `__syscall_fadvise64`. Split out from emscripten-core#22820.
sbc100
added a commit
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #20107