Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all ports to use build_port. NFC #17822

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Convert all ports to use build_port. NFC #17822

merged 1 commit into from
Sep 9, 2022

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 8, 2022

This will allow more easy transition to alternative build systems such as ninja (See #17809).

Also, update build_port to allow separate source and build directories. This avoids copying the entire source code of each port from the extracts archive into the build directory.

@sbc100 sbc100 requested a review from dschuff September 8, 2022 22:54
@sbc100 sbc100 force-pushed the use_build_port branch 2 times, most recently from 8fb6354 to 976ca97 Compare September 8, 2022 23:00
@sbc100 sbc100 enabled auto-merge (squash) September 8, 2022 23:04
@sbc100 sbc100 requested a review from kripken September 9, 2022 08:58
@sbc100 sbc100 force-pushed the use_build_port branch 4 times, most recently from 7000fda to e0dc01a Compare September 9, 2022 11:38
This will allow more easy transition to alternative build systems
such as ninja (See #17809).

Also, update build_port to allow separate source and build directories.
This avoids copying the entire source code of each port from the
extracts archive into the build directory.
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice simplification although I'm not super-familiar with this code...

tools/ports/__init__.py Show resolved Hide resolved
tools/ports/freetype.py Show resolved Hide resolved
@sbc100 sbc100 merged commit 6c2e5a6 into main Sep 9, 2022
@sbc100 sbc100 deleted the use_build_port branch September 9, 2022 16:14
sbc100 added a commit that referenced this pull request Sep 13, 2022
Should have been part of #17822.
sbc100 added a commit that referenced this pull request Sep 14, 2022
Should have been part of #17822.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants