Update library_glfw.js - use delta from getMouseWheelDelta(event) #16480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use delta from `getMouseWheelDelta(event)` when using GLFW 3. The adjustments made in #7968 (scaling mouse wheel delta) do not apply when using GLFW 3. This fixes that.
|
Are there any differences in GLFW 2 vs GLFW 3 documentation with respect to mouse wheel values? I suppose not, so this PR would make this more consistent? In either case, this will mess up all existing people's code for GLFW 3 mouse wheel scrolling. (I don't know how large the current GLFW3 userbase is though) So at minimum there should be a ChangeLog entry - can you add a line to ChangeLog.md about this? Apart from that, lgtm. |
juj
approved these changes
Mar 13, 2022
|
Thanks for the quick response. I added a line in ChangeLog.md. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use delta from
getMouseWheelDelta(event)when using GLFW 3. The adjustments made in #7968 (scaling mouse wheel delta) do not apply when using GLFW 3. This fixes that.