Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing SDL_strtokr.c #15985

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Fix missing SDL_strtokr.c #15985

merged 1 commit into from
Jan 14, 2022

Conversation

ericoporto
Copy link
Contributor

@ericoporto ericoporto commented Jan 12, 2022

Fix emscripten-ports/SDL2#159

I don't know why the CI doesn't run for my PRs.

@Daft-Freak
Copy link
Collaborator

Daft-Freak commented Jan 12, 2022

Looks like stdlib/SDL_crc32.c is also missing. I'll go check if I missed anything else... (made the mistake of assuming CI would catch everything)

EDIT: Found some more: locale/SDL_locale.c locale/emscripten/SDL_syslocale.c misc/SDL_url.c misc/dummy/SDL_sysurl.c

@ericoporto
Copy link
Contributor Author

ericoporto commented Jan 12, 2022

@Daft-Freak feel free to open a new PR with all of these, there's something that makes my PRs not trigger the CI, so I think you will be able to merge it sooner. Nonetheless, I added all the mentioned sources in case someone wants to merge these.

@kripken
Copy link
Member

kripken commented Jan 12, 2022

I filed a ticket now with circleci so I hope that CI will be fixed soon.

@ericoporto
Copy link
Contributor Author

ericoporto commented Jan 12, 2022

I rebased to a single commit, but the CI seems to not be working yet. The code changes are small.

Apparently it broke after: #15452

@kripken
Copy link
Member

kripken commented Jan 13, 2022

I still haven't heard back from circleci. Sorry about that. Let's give it another day - if they still do not respond I will both escalate with them + open a manual PR here myself with your changes to get test coverage.

@ericoporto
Copy link
Contributor Author

@kripken don't worry, have a good afternoon. Things always workout eventually. :)

@ericoporto ericoporto changed the title Fiz missing SDL_strtokr.c Fix missing SDL_strtokr.c Jan 14, 2022
@kripken
Copy link
Member

kripken commented Jan 14, 2022

Still no word so I pulled to a branch to force tests. Looks like there is a failure on linting, there is some whitespace added here, a space at the end of a line,

./tools/ports/sdl2.py:60:101: W291 trailing whitespace

https://app.circleci.com/pipelines/github/emscripten-core/emscripten/18276/workflows/ad31ba1b-d758-404a-9a89-1438d06e2b8c/jobs/493087

Aside from that tests are still running but looks good so far.

@ericoporto
Copy link
Contributor Author

I push forced and removed the trailing whitespace!

@kripken
Copy link
Member

kripken commented Jan 14, 2022

Tests finished, the only issue is the lint problem.

@kripken kripken merged commit 9ccc453 into emscripten-core:main Jan 14, 2022
@ericoporto ericoporto deleted the patch-4 branch January 14, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emscripten : error: undefined symbol: SDL_strtokr
3 participants