-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing SDL_strtokr.c #15985
Fix missing SDL_strtokr.c #15985
Conversation
Looks like EDIT: Found some more: |
@Daft-Freak feel free to open a new PR with all of these, there's something that makes my PRs not trigger the CI, so I think you will be able to merge it sooner. Nonetheless, I added all the mentioned sources in case someone wants to merge these. |
I filed a ticket now with circleci so I hope that CI will be fixed soon. |
I rebased to a single commit, but the CI seems to not be working yet. The code changes are small. Apparently it broke after: #15452 |
I still haven't heard back from circleci. Sorry about that. Let's give it another day - if they still do not respond I will both escalate with them + open a manual PR here myself with your changes to get test coverage. |
@kripken don't worry, have a good afternoon. Things always workout eventually. :) |
Still no word so I pulled to a branch to force tests. Looks like there is a failure on linting, there is some whitespace added here, a space at the end of a line,
Aside from that tests are still running but looks good so far. |
I push forced and removed the trailing whitespace! |
Tests finished, the only issue is the lint problem. |
Fix emscripten-ports/SDL2#159
I don't know why the CI doesn't run for my PRs.