Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid thread profiling functions completely when not enabled #15677

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Dec 1, 2021

Previously we were imports JS stubs for the profiling functions
even in release builds, which was increasing the code size
of all threaded programs.

Previously we were imports JS stubs for the profiling functions
even in release builds, which was increasing the code size
of all threaded programs.
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sbc100 sbc100 merged commit faf4790 into main Dec 1, 2021
@sbc100 sbc100 deleted the thread_profiling branch December 1, 2021 18:03
mmarczell-graphisoft pushed a commit to GRAPHISOFT/emscripten that referenced this pull request Jan 5, 2022
…ten-core#15677)

Previously we were imports JS stubs for the profiling functions
even in release builds, which was increasing the code size
of all threaded programs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants