Initial support for pthreads + dynamic linking #13245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
from
3594754 to
ba8e0d5
Compare
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
from
ba8e0d5 to
424ad10
Compare
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
from
424ad10 to
39b4e05
Compare
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
6 times, most recently
from
4c5afd5 to
973f7bc
Compare
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
from
973f7bc to
a571fd1
Compare
sbc100
added a commit
that referenced
this pull request
Jan 13, 2021
This avoids running this code than once in the case that run() is called several times during startup which happens when run dependencies are injected. Split out from #13245
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
from
a571fd1 to
07ae0b0
Compare
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
from
07ae0b0 to
3e588ab
Compare
sbc100
added a commit
that referenced
this pull request
Jan 13, 2021
This avoids running this code than once in the case that run() is called several times during startup which happens when run dependencies are injected. Split out from #13245
sbc100
added a commit
that referenced
this pull request
Jan 13, 2021
This avoids running this code than once in the case that run() is called several times during startup which happens when run dependencies are injected. Split out from #13245
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
from
3e588ab to
e7aa081
Compare
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
2 times, most recently
from
c0ba508 to
7f21f38
Compare
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
from
7f21f38 to
d927be3
Compare
kripken
approved these changes
Jan 14, 2021
Comment on lines
+271
to
+272
| // Loading of dynamic libraries needs to happen on each thread, so we can't | ||
| // use the normal __ATPRERUN__ mechanism. |
There was a problem hiding this comment.
Suggested change
| // Loading of dynamic libraries needs to happen on each thread, so we can't | |
| // use the normal __ATPRERUN__ mechanism. | |
| // Loading of dynamic libraries needs to happen on each thread, so we can't | |
| // use the normal __ATPRERUN__ mechanism. |
| #if MAIN_MODULE | ||
| preloadDylibs(); | ||
| #else | ||
| reportUndefinedSymbols(); |
There was a problem hiding this comment.
Not related to this PR, as it's pre-existing, but do you know why the main thread loads dylibs while the side module reports undefined symbols? That seems odd. I'd expect the main module to do both?
There was a problem hiding this comment.
Oh, wait, the side module has no JS. So basically, if it's relocatable but not a main module, it only reports undefined symbols, I guess?
There was a problem hiding this comment.
Indeed. Although I'm not really sure how much that configuration gets used .. I don't think we test it much.
This support is still experimental and has some major caveats: - Only supports load-time dynamic linking - No support for sharing TLS data between dylibs. The major change is that workers now also call the module `run` function although they exit realy once dynamic libraries have all been loaded. Another change is the dynamic library loading (which needs to run on each new worker) is now seperated from `__ATPRERUN__` (which only wants to run once on the main thread).
sbc100
force-pushed
the
pthreads_dynamic_linking2
branch
from
d927be3 to
d74bf16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This support is still experimental and has some major
caveats:
The major change is that workers now also call the module
runfunctionalthough they exit early once dynamic libraries have all been loaded.
Another change is the dynamic library loading (which needs to run on
each new worker) is now seperated from
__ATPRERUN__(which only wantsto run once on the main thread).
See: #3494