-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: CheckTypeSize does not work correctly for types > 255? #18238
Comments
The problem seems to date back to b206b9e. We apparently override CheckTypeSize but we use the return value of the executable, which is only allowed to be in the range 0-255. |
sbc100
added a commit
that referenced
this issue
Dec 2, 2022
Update the CheckTypeSize files to v3.20.0 (mostly arbitrary version). Local patch to CheckTypeSize is not much smaller. Instead of executing the program and using the return value (doesn't work for return values greater than 255), we simply inject `-oformat=wasm` onto the link command, and then we can use `strings` on the binary just like the upstream check. This is basically a single line patch against upstream now. Fixes: #18278 #18238 #17268 #18084 #17811
sbc100
added a commit
that referenced
this issue
Dec 2, 2022
Update the CheckTypeSize files to v3.10.2 (mostly arbitrary version, but this is what we use in CI). Local patch to CheckTypeSize is not much smaller. Instead of executing the program and using the return value (doesn't work for return values greater than 255), we simply inject `-oformat=wasm` onto the link command, and then we can use `strings` on the binary just like the upstream check. This is basically a single line patch against upstream now. Fixes: #18278 #18238 #17268 #18084 #17811
sbc100
added a commit
that referenced
this issue
Dec 5, 2022
Update the CheckTypeSize files to v3.10.2 (mostly arbitrary version, but this is what we use in CI). Local patch to CheckTypeSize is not much smaller. Instead of executing the program and using the return value (doesn't work for return values greater than 255), we simply inject `-oformat=wasm` onto the link command, and then we can use `strings` on the binary just like the upstream check. This is basically a single line patch against upstream now. Fixes: #18278 #18238 #17268 #18084 #17811
sbc100
added a commit
that referenced
this issue
Dec 5, 2022
Update the CheckTypeSize files to v3.10.2 (mostly arbitrary version, but this is what we use in CI). Local patch to CheckTypeSize is not much smaller. Instead of executing the program and using the return value (doesn't work for return values greater than 255), we simply inject `-oformat=wasm` onto the link command, and then we can use `strings` on the binary just like the upstream check. This is basically a single line patch against upstream now. This change also avoids a second issue which is that node failures (non-zero return codes) are indistinguishable from non-zero return codes from user code. Fixes: #18278 #18238 #17268 #18084 #17811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The custom shipped CheckTypeSize module does not handle types greater than 255 bytes correctly.
Version of emscripten/emsdk:
3.1.23
Testing source
The text was updated successfully, but these errors were encountered: