-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emconfigure fails inside "type": "module" package #13551
Comments
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
I see, it looks like the "#!" line that runs the emscripten "executables" under node is effected by package.json files. I guess we could/should override that in the |
This fixes hard-to-debug failures when any parent directory has package.json with {"type": "module"} in it. Before emconfigure / conftest could fail with config.log error: TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension "" The fix forces commonjs mode for generated Node scripts. fixes emscripten-core#13551 fixes emscripten-core#17431
Please see my #17451 (comment) for a possible fix. |
Repro:
And in config.log:
This could be solved if
emconfigure
added apackage.json
file in the current directory:The text was updated successfully, but these errors were encountered: