Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmap ignores offset #10094

Closed
petersalomonsen opened this issue Dec 22, 2019 · 0 comments · Fixed by #10095
Closed

mmap ignores offset #10094

petersalomonsen opened this issue Dec 22, 2019 · 0 comments · Fixed by #10095

Comments

@petersalomonsen
Copy link
Contributor

petersalomonsen commented Dec 22, 2019 •
edited
Loading

when passing the offset parameter to mmap it is ignored by the msync operation occuring on munmap

I hit this when compiling libgit2 with emscripten:
https://github.com/petersalomonsen/libgit2/blob/emscripten-support/src/indexer.c#L618

applying #10095 fixes the issue for me and makes it possible to clone using libgit2 compiled with emscripten (libgit2/libgit2#5345)
@petersalomonsen petersalomonsen mentioned this issue Dec 22, 2019
Merged
petersalomonsen added a commit to petersalomonsen/emscripten that referenced this issue Dec 22, 2019
@petersalomonsen
fix: handle mmap offset
aaec9db 
fixes emscripten-core#10094
petersalomonsen added a commit to petersalomonsen/emscripten that referenced this issue Dec 23, 2019
@petersalomonsen
fix: handle mmap offset
15f447e 
fixes emscripten-core#10094
petersalomonsen added a commit to petersalomonsen/emscripten that referenced this issue Dec 23, 2019
@petersalomonsen
fix: handle mmap offset
e41d357 
fixes emscripten-core#10094
petersalomonsen added a commit to petersalomonsen/emscripten that referenced this issue Dec 24, 2019
@petersalomonsen
fix: handle mmap offset
40674f4 
add and use offset parameter in doMsync
add test case for shared mmap with offset

fixes emscripten-core#10094
petersalomonsen added a commit to petersalomonsen/emscripten that referenced this issue Dec 24, 2019
@petersalomonsen
fix: handle mmap offset
9e4eb22 
add and use offset parameter in doMsync
add test case for shared mmap with offset

fixes emscripten-core#10094
kripken pushed a commit that referenced this issue Jan 6, 2020
@petersalomonsen @kripken
Handle mmap offset (#10095)
cab9e53 
Add and use offset parameter in doMsync

fixes #10094
belraquib pushed a commit to belraquib/emscripten that referenced this issue Dec 23, 2020
@petersalomonsen @belraquib
Handle mmap offset (emscripten-core#10095)
5d5220c 
Add and use offset parameter in doMsync

fixes emscripten-core#10094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle mmap offset petersalomonsen/emscripten
1 participant
@petersalomonsen