Skip to content

Commit

Permalink
Pin v8 version used in testing. NFC (#17847)
Browse files Browse the repository at this point in the history
test_async_hello_stack_switching fails under 10.7.187 and above.
  • Loading branch information
sbc100 authored Sep 14, 2022
1 parent cdbbefa commit e98554f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ executors:
EMTEST_WASI_SYSROOT: "~/wasi-sdk/wasi-sysroot"
EMTEST_BUILD_VERBOSE: "2"
EMTEST_DETECT_TEMPFILE_LEAKS: "1"
# Currently pinned due to https://github.com/emscripten-core/emscripten/issues/17846
V8_VERSION: "10.7.186"
mac:
environment:
EMSDK_NOTTY: "1"
Expand Down Expand Up @@ -82,7 +84,7 @@ commands:
# as a "bleeding edge" shell here, basically, with node being the
# primary shell (which we run without any special flags)
# Refer to commit 0bc3640 if we need to pin V8 version.
echo "V8_ENGINE = [os.path.expanduser('~/.jsvu/v8'), '--wasm-staging']" >> .emscripten
echo "V8_ENGINE = [os.path.expanduser('~/.jsvu/v8-${V8_VERSION}'), '--wasm-staging']" >> .emscripten
echo "JS_ENGINES = [NODE_JS]" >> .emscripten
echo "if os.path.exists(V8_ENGINE[0]): JS_ENGINES.append(V8_ENGINE)" >> .emscripten
echo "WASM_ENGINES = []" >> .emscripten
Expand Down Expand Up @@ -355,7 +357,7 @@ jobs:
export PATH="`pwd`/node-v12.13.0-linux-x64/bin:${PATH}"
npm install jsvu -g
export PATH="${HOME}/.jsvu:${PATH}"
jsvu --os=default --engines=v8
jsvu --os=default --engines=v8 v8@${V8_VERSION}
- build
- build-libs
- persist
Expand Down

0 comments on commit e98554f

Please sign in to comment.