Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin/command): contentType recompute new changed option #941

Merged

Conversation

Davidmattei
Copy link
Member

@Davidmattei Davidmattei commented Jul 3, 2024

Q A
Bug fix? n
New feature? y
BC breaks? n
Deprecations? n
Fixed tickets? n
Documentation? n

Added a new option 'changed' for only creating a new revision if needed. But still not fully correct because we need to sign twice, the sign method is also looking at the finalized_by & finalization_datetime. Created a new issue for this for discussion.

@Davidmattei Davidmattei self-assigned this Jul 3, 2024
@Davidmattei Davidmattei added this to the 5.19.0 milestone Jul 3, 2024
@Davidmattei Davidmattei linked an issue Jul 3, 2024 that may be closed by this pull request
@probot-autolabeler probot-autolabeler bot added the documentation Improvements or additions to documentation label Jul 10, 2024
@Davidmattei Davidmattei marked this pull request as ready for review July 10, 2024 13:42
@Davidmattei Davidmattei requested a review from a team as a code owner July 10, 2024 13:42
@Davidmattei Davidmattei changed the title feat(core/cli): contentType recompute new changed option test contentType recompute new changed option Jul 10, 2024
@Davidmattei Davidmattei changed the title test contentType recompute new changed option feat(core/cli): contentType recompute new changed option Jul 10, 2024
@Davidmattei Davidmattei merged commit 2f14f89 into ems-project:5.x Jul 10, 2024
2 of 3 checks passed
@Davidmattei Davidmattei changed the title feat(core/cli): contentType recompute new changed option feat(admin/command): contentType recompute new changed option Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common-bundle core-bundle documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

admin: ems:contenttype:recompute only new revision for updates
2 participants