chore: upgrade phpUnit 9 -> 11 #1147
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Davidmattei
commented
Jan 18, 2025
Davidmattei
commented
| Q | A |
|---|---|
| Bug fix? | n |
| New feature? | n |
| BC breaks? | n |
| Deprecations? | n |
| Fixed tickets? | n |
| Documentation? | n |
- remove phpunit from bundles and packages
probot-autolabeler
bot
added
admin-ui-bundle
elasticms-admin
elasticms-cli
elasticms-web
documentation
We only run phpunit inside the mono-repo.
We have a monorepo
Phpstan & php-cs-fixer is run inside monorepo only
Removed the final from the classes so the test can mock. No need for the extra dependency for making mocking final classes.
Davidmattei
force-pushed
the
chore/phpunit-11
branch
from
cac9fcd to
7076559
Compare
Tests are not in de src directory, so not needed to exclude them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.