Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web/local): upload assets heads returns true #1105

Merged

Conversation

Davidmattei
Copy link
Member

Q A
Bug fix? y
New feature? n
BC breaks? n
Deprecations? n
Fixed tickets? n
Documentation? n

Problem:

php bin/console emsch:local:upload-assets

Local development - Upload assets
=================================

                                                                                                                        
 [ERROR] File with hash 1 not found                                                                                     
                                                                                                                        

Since 5.24.0 -> #1076
The heads api is returning string|true.

But the true check was not implemented in the UploadAssetsCommand

@Davidmattei Davidmattei requested a review from a team as a code owner December 11, 2024 07:43
@Davidmattei Davidmattei added this to the 5.23.5 - 5.24.3 milestone Dec 11, 2024
@Davidmattei Davidmattei self-assigned this Dec 11, 2024
@Davidmattei Davidmattei merged commit b19256b into ems-project:5.24 Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants