fix(otel_metrics): use `opentelemetry:timestamp/0` (native unit monotonic time) #3

SergeTupchiy · 2023-10-24T12:12:36Z

Timestamps are converted to Unix nano timestamps by the exporter.
The previous usage of system_time resulted in treating system_time nanosecond as monotonic time in native time units.

Fixes: emqx/emqx#11802

…onic time) Timestamps are converted to Unix nano timestamps by the exporter.

zhongwencool

LGTM

SergeTupchiy · 2023-10-25T10:09:08Z

Thanks @zhongwencool,
this fix was also approved in the upstream repo (open-telemetry#644) but it's hard to predict when it will be merged, so I'll merge this PR and tag a new emqx release.

fix(otel_metrics): use opentelemetry:timestamp/0 (native unit monot…

f44c4c6

…onic time) Timestamps are converted to Unix nano timestamps by the exporter.

zhongwencool approved these changes Oct 25, 2023

View reviewed changes

SergeTupchiy merged commit 7566d58 into emqx:main Oct 25, 2023

SergeTupchiy mentioned this pull request Nov 10, 2023

fix(otel_otlp_metrics): convert histogram timestamps #5

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(otel_metrics): use `opentelemetry:timestamp/0` (native unit monotonic time) #3

fix(otel_metrics): use `opentelemetry:timestamp/0` (native unit monotonic time) #3

SergeTupchiy commented Oct 24, 2023 •

edited

Loading

zhongwencool left a comment

SergeTupchiy commented Oct 25, 2023

fix(otel_metrics): use opentelemetry:timestamp/0 (native unit monotonic time) #3

fix(otel_metrics): use opentelemetry:timestamp/0 (native unit monotonic time) #3

Conversation

SergeTupchiy commented Oct 24, 2023 • edited Loading

zhongwencool left a comment

Choose a reason for hiding this comment

SergeTupchiy commented Oct 25, 2023

fix(otel_metrics): use `opentelemetry:timestamp/0` (native unit monotonic time) #3

fix(otel_metrics): use `opentelemetry:timestamp/0` (native unit monotonic time) #3

SergeTupchiy commented Oct 24, 2023 •

edited

Loading