ci: run tests and build releases under recent OTP-24/25 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a part of build-packaged workflow for a long time.
keynslug
force-pushed
the
chore/otp-25-builds
branch
5 times, most recently
from
443807c to
e367222
Compare
Also simplify workflows where possible.
Also fallback to rebar3 3.19.0 when system-wide one is unavailable.
So that Github won't complain that we're running on outdated Node.js runtime anymore.
This check wasn't working as expected anyway and silently passed because of the lack of quoting in the test expression.
keynslug
force-pushed
the
chore/otp-25-builds
branch
from
e367222 to
135400b
Compare
qzhuyan
approved these changes
Jan 3, 2023
id
reviewed
Jan 3, 2023
| - uses: actions/checkout@v1 | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Because the build script needs some recent git tag, and the checkout action fetches tags only if fetch-depth: 0. Strictly speaking that might be unnecessary because the build script works even without tags, and the checkout action seems smart enough to setup git tag in shallow clones during release-triggered workflow runs. I'll remove that line.
There was a problem hiding this comment.
Well, that didn't work for a different reason, packaging scripts became confused.
Co-authored-by: Ivan Dyachkov <[email protected]>
keynslug
force-pushed
the
chore/otp-25-builds
branch
from
4e88535 to
0b93a83
Compare
id
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplify workflows where possible.
EMQX-8562