* UPDATE add demo as default compiling option #152
Closed
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanghaEMQ
previously approved these changes
Mar 30, 2023
alvin1221
approved these changes
Mar 30, 2023
CMakeLists.txt
Outdated
| @@ -267,6 +267,7 @@ endif () | |||
| # Build the tools | |||
|
|
|||
| add_subdirectory(docs/man) | |||
| add_subdirectory(demo) | |||
There was a problem hiding this comment.
I suggest add an cmake option to decide build demos or not
JaylinYu
force-pushed
the
jaylin/nanosdk
branch
2 times, most recently
from
604eb9d to
3a7b002
Compare
JaylinYu
force-pushed
the
jaylin/nanosdk
branch
from
3a7b002 to
c06a705
Compare
aguasonic
approved these changes
Jun 1, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 59.23% 59.25% +0.02%
==========================================
Files 96 96
Lines 26428 26440 +12
==========================================
+ Hits 15654 15667 +13
+ Misses 10774 10773 -1
☔ View full report in Codecov by Sentry. |
|
Did you overwrite your commits? The changes in CMakeLists.txt disappeared |
|
done by #225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.