Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connection): remove client property on connection model #642

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Jul 26, 2021

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Every connection model has a client property.

Issue Number

Example: None

What is the new behavior?

Remove client on connection.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added enhancement New feature or request refactor Refactor code or architecture labels Jul 26, 2021
@ysfscream ysfscream requested a review from oceanlvr July 26, 2021 07:46
@oceanlvr oceanlvr merged commit 75cd8c5 into master Jul 27, 2021
@oceanlvr oceanlvr deleted the ysf/dev branch July 27, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactor code or architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants