Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connections): add throttle to the send message button #1831

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

Red-Asuka
Copy link
Member

@Red-Asuka Red-Asuka commented Dec 10, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

When clicking the send button too quickly, received messages get replaced by sent messages, leading to message loss

Issue Number

#1614 #1770

What is the new behavior?

Throttle the send message button to avoid rendering errors in the message list that may be caused by sending messages quickly in a short period.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@Red-Asuka Red-Asuka added fix Fix bug or issues desktop MQTTX Desktop labels Dec 10, 2024
@Red-Asuka Red-Asuka added this to the v1.11.1 milestone Dec 10, 2024
@Red-Asuka Red-Asuka requested a review from ysfscream December 10, 2024 10:11
@Red-Asuka Red-Asuka self-assigned this Dec 10, 2024
@ysfscream
Copy link
Member

ysfscream commented Dec 11, 2024

Please wait for me to test for data timing issues before merging. And I updated your PR template. Make the info more complete.

@ysfscream ysfscream merged commit 0467742 into main Dec 12, 2024
2 checks passed
@ysfscream ysfscream deleted the lyd/dev branch December 12, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop fix Fix bug or issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants