Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(desktop): add mqtt properties component #1819

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #123

What is the new behavior?

This pull request introduces changes to the MqttProperties and TreeNodeInfo components to improve the display and styling of MQTT properties. The most important changes include adding a new showColon prop, updating the template to use the new prop, and integrating the MqttProperties component into TreeNodeInfo.

Enhancements to MqttProperties component:

  • Added a new showColon prop to control the display of a colon after the property label.
  • Updated the template to use the new showColon prop and improved the structure of the property display.

Integration with TreeNodeInfo component:

  • Imported the MqttProperties component and registered it locally in TreeNodeInfo.
  • Integrated the MqttProperties component into the TreeNodeInfo template to display MQTT properties.

Styling updates:

  • Added new styles to TreeNodeInfo to enhance the appearance of the MqttProperties component.
image

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added enhancement New feature or request feature This pr is a feature desktop MQTTX Desktop labels Nov 22, 2024
@ysfscream ysfscream requested a review from Red-Asuka November 22, 2024 09:57
@ysfscream ysfscream self-assigned this Nov 22, 2024
@ysfscream ysfscream added this to the v1.11.1 milestone Nov 22, 2024
@Red-Asuka Red-Asuka merged commit 72c4341 into main Nov 25, 2024
2 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch November 25, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants