-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve(desktop): improve experience with avro #1762
Conversation
Something weird happens when importing 'xxx.json' file as avro schema. Though the filename readed from the file system ends with '.json', a '.avsc' is added to the end of the filename: renaming it to 'xxx.json.avsc' after it's journey to the database. Howerver, since the filtering logic of selecting imported schema is by examining their extensions, this strange 'xxx.json.avsc' name surprisingly does not require any further processing to be listed in the options in the schema tab. That being said, I still hope the reason of this strange process to be found. |
Editor lang for protobuf schema is set to 'plaintext'
I will test locally to find the issue. Thanks for your report. |
@LAST7, in this PR #1764, I fixed the issue of file extensions. This isn't a strange problem. In the code, every import automatically adds a suffix. However, there needs to be a solution with logical judgment. So, I made a quick fix. Briefly speaking, it checks if the file extension is correct. If it's incorrect, it deletes it and adds the expected suffix. Although the |
Ah, I see the reason now. THX! |
PR Checklist
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information