Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop): Msg pack support #1760

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

lantica
Copy link
Contributor

@lantica lantica commented Sep 16, 2024

PR Checklist

What is the new behavior?

Add support for Message Pack payload encoding and decoding.

Does this PR introduce a breaking change?

  • Yes
  • No

@lantica lantica changed the title Msg pack support feat(desktop): Msg pack support Sep 17, 2024
@ysfscream ysfscream added feature This pr is a feature desktop MQTTX Desktop labels Sep 17, 2024
@ysfscream ysfscream added this to the v1.11.0 milestone Sep 17, 2024
@ysfscream ysfscream added the CLI MQTTX CLI label Sep 17, 2024
@ysfscream
Copy link
Member

Thank you so much for your contribution! However, there are some errors in the CI. Could you please take a look and fix the issue?

Also, could you provide more usage documentation, such as feature descriptions and screenshots? Additionally, please mention some problems that will be resolved. 😊

@ysfscream ysfscream requested a review from LAST7 September 18, 2024 01:30
@ysfscream
Copy link
Member

Ref: https://msgpack.org/

@ysfscream
Copy link
Member

Since the developer has not responded and I want to release this function in 1.11.0. Therefore, I merge this PR first. Subsequent fixes and optimizations will be done locally.

@ysfscream ysfscream merged commit a7b5252 into emqx:main Sep 26, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI MQTTX CLI desktop MQTTX Desktop feature This pr is a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants