Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(desktop): add avro util test cases #1759

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

LAST7
Copy link
Collaborator

@LAST7 LAST7 commented Sep 15, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

image

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

Sorry, something went wrong.

rename function(s) in src/utils/avro.ts
update error message
@ysfscream ysfscream assigned ysfscream and LAST7 and unassigned ysfscream Sep 17, 2024
@ysfscream ysfscream added desktop MQTTX Desktop test labels Sep 17, 2024
@ysfscream ysfscream added this to the v1.11.0 milestone Sep 17, 2024
Copy link
Member

@ysfscream ysfscream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i will merge first.

@ysfscream ysfscream merged commit 2a8e771 into emqx:main Sep 17, 2024
2 checks passed
@LAST7 LAST7 deleted the avro-test branch September 18, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants