Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): add experimental option in tsconfig to fit modern lsp #1758

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

LAST7
Copy link
Collaborator

@LAST7 LAST7 commented Sep 11, 2024

modern lsp like volar would complain about variables used in template without this option.

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

image

What is the new behavior?

image

error in line 23 is already addressed in another pr.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Haven't tried it on VSCode, but since I'm using the same lsp as VSCode popular plugin uses, it should behave the same.

…dern lsp

modern lsp like volar would complain about variables used in template
without this option.
@LAST7 LAST7 requested a review from ysfscream September 11, 2024 05:31
@LAST7 LAST7 added the chore Changes in build tools or dependent packages label Sep 11, 2024
@LAST7 LAST7 self-assigned this Sep 11, 2024
@ysfscream ysfscream requested a review from Red-Asuka September 11, 2024 05:44
@ysfscream ysfscream added the desktop MQTTX Desktop label Sep 11, 2024
@ysfscream ysfscream added this to the v1.11.0 milestone Sep 11, 2024
@ysfscream
Copy link
Member

@LAST7, thank you so much for your contribution! LGTM. However, I noticed that this configuration seems to be a deprecated item. But it's fine for the moment.

image

@ysfscream ysfscream merged commit 821ac5b into emqx:main Sep 11, 2024
2 checks passed
@LAST7 LAST7 deleted the tsconfig branch September 12, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes in build tools or dependent packages desktop MQTTX Desktop
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants