Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): mqtt version 5 -> 5.0 #1745

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(cli): mqtt version 5 -> 5.0 #1745

merged 1 commit into from
Sep 3, 2024

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

-V, --mqtt-version <5/3.1.1/3.1> 

Issue Number

Example: #123

What is the new behavior?

-V, --mqtt-version <5.0/3.1.1/3.1> 

5.0 and 5 are supported as option values on the CLI, but 5.0 is more precise.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream requested a review from Red-Asuka September 2, 2024 08:19
@ysfscream ysfscream self-assigned this Sep 2, 2024
@ysfscream ysfscream added CLI MQTTX CLI enhancement New feature or request labels Sep 2, 2024
@ysfscream ysfscream added this to the v1.11.0 milestone Sep 2, 2024
@Red-Asuka Red-Asuka merged commit e5ced55 into main Sep 3, 2024
4 checks passed
@Red-Asuka Red-Asuka deleted the ysf/cli branch September 3, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI MQTTX CLI enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants