feat(cli): add global command mock for tests and enhance filterOption…

…s to use dynamic source
emqx · Nov 15, 2024 · dd49696 · dd49696
1 parent c5b1ef6
commit dd49696
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/cli/src/__tests__/utils/options.test.ts b/cli/src/__tests__/utils/options.test.ts
@@ -3,12 +3,18 @@
 import { handleSaveOptions, handleLoadOptions } from '../../utils/options'
 import { existsSync, unlinkSync } from 'fs'
 import { join } from 'path'
-import { expect, afterAll, describe, it } from '@jest/globals'
+import { expect, afterAll, describe, it, jest, beforeAll } from '@jest/globals'
 
 const testFilePath = join(__dirname, 'test-options.json')
 const defaultPath = join(process.cwd(), 'mqttx-cli-options.json')
 
 describe('options', () => {
+  beforeAll(() => {
+    global.command = {
+      getOptionValueSource: jest.fn().mockReturnValue('cli'),
+    } as any
+  })
+
   afterAll(() => {
     if (existsSync(testFilePath)) {
       unlinkSync(testFilePath)

diff --git a/cli/src/utils/options.ts b/cli/src/utils/options.ts
@@ -35,7 +35,7 @@ const removeUselessOptions = (
  */
 const filterOptions = <T extends OptionsType>(source: OptionValueSource, opts: T): Partial<T> => {
   return Object.fromEntries(
-    Object.entries(opts).filter(([key]) => globalThis.command.getOptionValueSource(key) === 'cli'),
+    Object.entries(opts).filter(([key]) => globalThis.command.getOptionValueSource(key) === source),
   ) as Partial<T>
 }