Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename search-types to x-types #928

Merged
merged 5 commits into from
Jan 4, 2023
Merged

feat: rename search-types to x-types #928

merged 5 commits into from
Jan 4, 2023

Conversation

yokishava
Copy link
Contributor

@yokishava yokishava commented Dec 15, 2022 •
edited
Loading

Motivation and context

I saw the following issue and renamed it to be x-package.

#920

Normally, the scope of change should be reduced according to CONTRIBUTION.md. However, the scope of change is naturally larger this time because of the change of directory name.

  • Open issue. If applicable, link:

Type of change

  • Change requires a documentation update

What is the destination branch of this PR?

  • Main

Checklist:

  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@yokishava yokishava requested review from a team as code owners December 15, 2022 13:43
@herrardo herrardo linked an issue Dec 15, 2022 that may be closed by this pull request
[FEATURE]: Rename search-types folder as x-types #920
Closed
1 task
alvaropanizo
alvaropanizo previously approved these changes Dec 15, 2022
View reviewed changes
Copy link

@alvaropanizo alvaropanizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

diegopf
diegopf requested changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@diegopf diegopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Please, take a look at my comment

package-lock.json Outdated Show resolved Hide resolved
@yokishava yokishava requested a review from diegopf December 20, 2022 03:24
diegopf
diegopf requested changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@diegopf diegopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that now there are some conflicts with the main branch, would you be so kind to solve them? Thanks again for the PR! 🚀

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/x-components/static-docs/build-search-ui/web-x-components-development-guide.md Show resolved Hide resolved
herrardo
herrardo reviewed Jan 2, 2023
View reviewed changes
Copy link
Contributor

@herrardo herrardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yokishava could you check the pending changes requested? Thanks!

@yokishava yokishava force-pushed the feature/rename-search-types branch 3 times, most recently from c6055dd to 4717b69 Compare January 2, 2023 14:19
@yokishava yokishava requested a review from diegopf January 2, 2023 14:21
@yokishava
Copy link
Contributor Author

yokishava commented Jan 2, 2023 •
edited
Loading

@herrardo Sorry for the delay in correcting this. I fixed it just now.

diegopf
diegopf previously approved these changes Jan 2, 2023
View reviewed changes
herrardo
herrardo previously approved these changes Jan 2, 2023
View reviewed changes
@yokishava yokishava dismissed stale reviews from herrardo and diegopf via 219a1f5 January 3, 2023 03:30
@yokishava yokishava force-pushed the feature/rename-search-types branch from f0731c8 to 219a1f5 Compare January 3, 2023 03:30
@mnavarroespinosa mnavarroespinosa merged commit 1ac0008 into empathyco:main Jan 4, 2023
@mnavarroespinosa
Copy link
Contributor

Thanks a lot for your contribution @yokishava! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegopf diegopf diegopf approved these changes

@herrardo herrardo herrardo approved these changes

@alvaropanizo alvaropanizo alvaropanizo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Rename search-types folder as x-types
5 participants
@yokishava @mnavarroespinosa @herrardo @alvaropanizo @diegopf