Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add position on Banner and Promoted models #800

Merged

Conversation

alvarodE
Copy link
Contributor

@alvarodE alvarodE commented Oct 27, 2022

EX-7293, EX-7294 (both subtasks added in together as they are dependent).

@alvarodE alvarodE marked this pull request as ready for review October 27, 2022 07:39
@alvarodE alvarodE requested a review from a team as a code owner October 27, 2022 07:39
@alvarodE alvarodE changed the title Add position on Banner and Promoted models feat: Add position on Banner and Promoted models Oct 27, 2022
Copy link
Contributor

@tiborux tiborux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj

@tiborux tiborux self-assigned this Oct 28, 2022
@ajperezbau ajperezbau self-requested a review October 31, 2022 10:24
@ajperezbau ajperezbau self-assigned this Oct 31, 2022
Copy link
Contributor

@ajperezbau ajperezbau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@ajperezbau ajperezbau merged commit e7393fb into main Oct 31, 2022
@alvarodE alvarodE deleted the feature/EX-7293-add-position-on-banner-and-promoted-model branch October 31, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants