Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tagging): make tagging and queryTagging optional #797

Merged

Conversation

mnavarroespinosa
Copy link
Contributor

BREAKING CHANGE: tagging property of Taggable and queryTagging property of SearchResponse are optional.

EX-7231

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EX-7231

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

BREAKING CHANGE: `tagging` property of `Taggable` and `queryTagging` property of `SearchResponse` are optional.

EX-7231
@diegopf diegopf self-requested a review October 21, 2022 12:07
@diegopf diegopf merged commit 0e49156 into main Oct 21, 2022
@diegopf diegopf deleted the feature/EX-7231-make-tagging-and-query-tagging-optional branch October 21, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants