Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): add filters to base-suggestions #758

Merged
merged 18 commits into from
Nov 3, 2022
Merged

feat(components): add filters to base-suggestions #758

merged 18 commits into from
Nov 3, 2022

Conversation

ajperezbau
Copy link
Contributor

@ajperezbau ajperezbau requested a review from a team as a code owner October 5, 2022 15:14
@javieri-empathy javieri-empathy self-assigned this Oct 7, 2022
@javieri-empathy javieri-empathy self-requested a review October 7, 2022 06:12
javieri-empathy
javieri-empathy suggested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@javieri-empathy javieri-empathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, it works!

packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestion.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestion.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestion.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/design-system/components/suggestion/default.tokens.scss Show resolved Hide resolved
@luismmdev luismmdev self-requested a review October 10, 2022 07:37
luismmdev
luismmdev suggested changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@luismmdev luismmdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

packages/x-components/src/components/suggestions/base-suggestion.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestions.vue Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
packages/x-components/src/design-system/components/suggestion/default.tokens.scss Show resolved Hide resolved
packages/x-components/src/x-modules/query-suggestions/components/__tests__/utils.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestions.spec.ts Outdated Show resolved Hide resolved
ajperezbau
ajperezbau commented Oct 24, 2022
View reviewed changes
Copy link
Contributor Author

@ajperezbau ajperezbau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome refactor 👏

packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestions.spec.ts Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestion.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
@luismmdev @ajperezbau
Apply suggestions from code review
7a0dd94 
Co-authored-by: Abraham Javier Pérez Bautista <[email protected]>
luismmdev
luismmdev suggested changes Oct 26, 2022
View reviewed changes
packages/x-components/src/__stubs__/base-suggestion-stubs.factory.ts Outdated Show resolved Hide resolved
packages/x-components/src/__stubs__/base-suggestion-stubs.factory.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestions.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestions.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestions.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/design-system/components/suggestion/default.scss Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestions.vue Outdated Show resolved Hide resolved
javieri-empathy
javieri-empathy suggested changes Oct 26, 2022
View reviewed changes
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestion.vue Outdated Show resolved Hide resolved
packages/x-components/src/components/suggestions/base-suggestion.vue Outdated Show resolved Hide resolved
ajperezbau
ajperezbau commented Oct 29, 2022
View reviewed changes
Copy link
Contributor Author

@ajperezbau ajperezbau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👌

packages/x-components/src/components/suggestions/base-suggestion.vue Outdated Show resolved Hide resolved
packages/search-types/src/schemas/suggestion.schema.ts Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Show resolved Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts Show resolved Hide resolved
@ajperezbau
Copy link
Contributor Author

Looks good to me! 👌

luismmdev
luismmdev previously approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@luismmdev luismmdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job everyone

javieri-empathy
javieri-empathy previously approved these changes Nov 2, 2022
View reviewed changes
@javieri-empathy javieri-empathy dismissed stale reviews from luismmdev and themself via f088d77 November 2, 2022 10:09
luismmdev
luismmdev previously approved these changes Nov 2, 2022
View reviewed changes
@ajperezbau ajperezbau requested a review from luismmdev November 2, 2022 10:44
@javieri-empathy javieri-empathy merged commit 2014861 into main Nov 3, 2022
@diegopf diegopf deleted the feature/EX-6346-add-filters-to-base-suggestions branch September 6, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javieri-empathy javieri-empathy javieri-empathy approved these changes

@luismmdev luismmdev Awaiting requested review from luismmdev

Assignees

@luismmdev luismmdev

@javieri-empathy javieri-empathy

@ajperezbau ajperezbau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajperezbau @luismmdev @javieri-empathy