fix: Remove @empathyco/x-platform-adapter dependency from library c…
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajespasarela
suggested changes
Jun 23, 2022
| SearchResponse | ||
| } from './response'; | ||
|
|
||
| export interface XComponentsAdapter { |
There was a problem hiding this comment.
add a TODO to relax types
There was a problem hiding this comment.
and create a task in backlog and add link to this TODO
| } | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Add TODO in line 50 to add future logger
| @@ -24,15 +24,15 @@ import { assertXPluginOptionsAreValid } from './x-plugin.utils'; | |||
| */ | |||
| export class XPlugin implements PluginObject<XPluginOptions> { | |||
| /** | |||
| * {@link @empathyco/x-adapter-platform#PlatformAdapter | PlatformAdapter} Is the middleware | |||
| * {@link @empathyco/x-typesm#XComponentsAdapter | XComponentsAdapter} Is the middleware | |||
There was a problem hiding this comment.
Update the doc @example in line 419
There was a problem hiding this comment.
Updated clarifying usage, but it is an intended example.
tajespasarela
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptertype. This has no sense and it was complicated.XComponentsAdaptertype to@empathyco/x-types. Together with the rest of the request/responses info.x-typescan be considered as a package where all the shared types needed mainly by x-components, and other packages are.getTaggingInfoFromUrlto@empathyco/x-platform-adapter. This utility was previously in@empathyco/x-utils. Due to the refactor of the types it created a cyclic dependency.PlatformAdapterextendable.