ci(eslint): add eslint-plugin-xdependency
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmfempathy
suggested changes
Jul 22, 2021
| { | ||
| "extends": ["plugin:@empathyco/x/all"], | ||
| "rules": { | ||
| "@typescript-eslint/restrict-template-expressions": ["off", { "allowAny": true }], |
There was a problem hiding this comment.
I've noticed that both problems come from: x/packages/jest-utils/src/jest-utils.ts.
Isn't it preferable to disable both rules at least just for that file ?
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "extends": "./tsconfig.json", | |||
There was a problem hiding this comment.
Can we just have everything in the tsconfig.eslint.json instead of extending it from another file?
There was a problem hiding this comment.
this is how its done in other packages
| @@ -1,22 +1,23 @@ | |||
| export interface EmpathyExtendedExpect { | |||
| arrayOf(classType: Newable): any; | |||
| arrayOfItemsMatching(schema: {}): any; | |||
| arrayOfItemsMatching(schema: Record<string, any>): any; | |||
There was a problem hiding this comment.
Just for my information, did the linter complain about this?
There was a problem hiding this comment.
the linter doesn't like to use an empty object, so i added a record
|
@CachedaCodes we dont have types and js files in this package |
CachedaCodes
approved these changes
Jul 23, 2021
davidmfempathy
approved these changes
Jul 23, 2021
tajespasarela
deleted the
feature/EX-4317-add-eslint-plugin-x-to-x-jest-ut_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eslint-plugin-x