Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x-types): Fix filters models inheritance. #51

Merged
merged 2 commits into from
Jul 23, 2021
Merged

fix(x-types): Fix filters models inheritance. #51

merged 2 commits into from
Jul 23, 2021

Conversation

tajespasarela
Copy link
Contributor

EX-4449

Finally It was just a couple of changes:

1- Make the BooleanFilter and the EditableNumberRangeFilter to inherit from FacetFilter
2-Fix Schemas
3-Delete the value field in the BooleanFilter. The id is what we will use as value from now.

@tajespasarela tajespasarela requested a review from a team as a code owner July 21, 2021 12:57
@CachedaCodes CachedaCodes merged commit 01b6b1e into main Jul 23, 2021
@tajespasarela tajespasarela deleted the EX-4449-refactor-filters-models branch July 27, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CachedaCodes CachedaCodes CachedaCodes approved these changes

@tiborux tiborux tiborux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tajespasarela @tiborux @CachedaCodes