-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update eslint-plugin dependencies #447
build(deps): update eslint-plugin dependencies #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should set the new rules to warn
instead of entirely disabling them with off
, so in the future we know we have to refactor our code to make them work properly. Disabling them is going to make it harder for us to know which ones we should be reactivating later.
packages/x-components/src/x-modules/next-queries/components/next-queries-list.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job dealing with the huge amount of errors and warnings!👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing job 👏🏿 👏🏿
Update eslint-plugin dependencies to the latest version. Change the versions in the package to be 'patch' instead of minor.
This task: https://searchbroker.atlassian.net/browse/EX-5964 has the different rules applied. We should check it in the future and remove them to fix the problems.
EX-5383