Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update eslint-plugin dependencies #447

Merged
merged 11 commits into from
Apr 29, 2022

Conversation

tiborux
Copy link
Contributor

@tiborux tiborux commented Apr 22, 2022

Update eslint-plugin dependencies to the latest version. Change the versions in the package to be 'patch' instead of minor.

This task: https://searchbroker.atlassian.net/browse/EX-5964 has the different rules applied. We should check it in the future and remove them to fix the problems.

EX-5383

@tiborux tiborux requested a review from a team as a code owner April 22, 2022 07:41
Copy link
Contributor

@luismmdev luismmdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should set the new rules to warn instead of entirely disabling them with off, so in the future we know we have to refactor our code to make them work properly. Disabling them is going to make it harder for us to know which ones we should be reactivating later.

packages/eslint-plugin-x/package.json Outdated Show resolved Hide resolved
packages/x-components/.eslintrc.js Outdated Show resolved Hide resolved
packages/x-adapter/src/schemas/schemas.types.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@diegopf diegopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job dealing with the huge amount of errors and warnings!👏

package.json Outdated Show resolved Hide resolved
packages/eslint-plugin-x/lib/configs/imports.js Outdated Show resolved Hide resolved
packages/eslint-plugin-x/lib/configs/ts.js Outdated Show resolved Hide resolved
@tiborux tiborux requested review from luismmdev and diegopf April 29, 2022 08:15
packages/eslint-plugin-x/lib/configs/jsdoc.js Outdated Show resolved Hide resolved
packages/eslint-plugin-x/lib/configs/vue.js Outdated Show resolved Hide resolved
@luismmdev luismmdev self-requested a review April 29, 2022 08:52
luismmdev
luismmdev previously approved these changes Apr 29, 2022
Copy link
Contributor

@luismmdev luismmdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing job 👏🏿 👏🏿

diegopf
diegopf previously approved these changes Apr 29, 2022
@diegopf diegopf merged commit 51d60f0 into main Apr 29, 2022
@diegopf diegopf deleted the feature/EX-5383-update-eslint-plugin-x-dependenc branch April 29, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants