Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add adapter for related prompts #1641

Merged
merged 46 commits into from
Oct 28, 2024
Merged

Conversation

victorcg88
Copy link
Contributor

Pull request template

Add the adapter for the upcoming Related Prompts module.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

victorcg88 and others added 30 commits July 23, 2024 17:05
* feat(x-installer): update to vue3 and adapt x-installer

* feat(x-installer): simplify internal createApp fn

* feat(scroll): fix import path

* feat(component): keep injector const export

* feat(mixins): removing deprecated mixins
BREAKING-CHANGE: refactors the GlobalXBus to use a prop to receive the listeners instead of relying on attributes.
This PR resolves several warnings when running the internal demo app:

- Initial warning about overwriting the store modules.
- Warnings about `v-on="listeners"` deprecation.
- Removal of `v-bind="attrs"` and `inheritAttrs=false`, because Vue3 implemented by default the attributes inheritance.
- Fixing warning on `attrs` inheritance in RenderlessFilter.
- Fixing some components that throw warnings because the render function was incorrect.
…rective and deprecated layouts (#1576)

* get rid of deprecated `MultiColumnMaxWidthLayout`

* Revert "get rid of deprecated `MultiColumnMaxWidthLayout`"

This reverts commit 7fd0374.

* fix(list-components): fix list components, migrate infinite-scroll directive and deprecated layouts

* fix(list-components): avoid injecting undefined default value since Vue does it
* refactor(animation-factory): fix Vue3 breaking changes

* refactor(animation-factory): await animation to load

* refactor(animation-factory): improve type infer

* refactor(animations): Vue3 transition class breaking change
* test(components): propsData is now props

* test(components): revert skip on test cases

* test(components): fix duplicated bus instance

* test(components): provide moved inside global property

* test(components): remove useless nextTick()

* test(components): update jsdoc for installNewXPlugin()
BREAKING CHANGE: @empathyco/x-archetype-utils is only compatible with vue 3
BREAKING CHANGE:

@empathyco/x-components v6 and @empathyco/x-archetype-utils v2 are only compatible with Vue 3 and if you are looking for the Vue 2 versions, take look at the main brach.
* test: fix experience-controls and tagging tests

* test: fix scroll module and clear-search-input tests

* test:fix related-tag test

* test: fix tests in search module

* test: fix tests in history-queries module

* test: fix x-modules tests

* tests: QueryPreview

* test: fix semantic queries test

* test: fix semantic query test

* test: fix x-modules tests

* test: query preview button test

* test: use queries preview composable

* test: queries preview getter

* fix e2e tests

* fix e2e tests

* test: rm unneeded reset in queries preview composable

* test: query preview actions test

* test: query preview utils test

* test: fix x-modules tests

* test: fix x-modules tests

* test: query preview list test

* test: fix facets module tests

* test: adjust some filters lists tests

* test: facets getter test

* test: use-filters-injection composable

* test: fix facets module tests

* test: test facets-service

* test: adapt some filters tests

* test: rm localVue from url module's utils

* test: fix tagging actions test

* test: fix pdp-add-to-cart service

* test: fix search button test

* test: fix semantics module tests

* test: fix experience-controls getter test

* test: adjust selected-filters-list test

* test: fix getters-proxy.spec.ts

* test: fix search input test

* test: fix search input placeholder test

* test: fix search box module actions test

* test: fix facets-provider.spec.ts

* test: adjust preselected-filters test

* test: fix base-event-button and use-x-bus test sheets

* test: fix test sheets of filter components

* test: fix highlight and result-variants-provider-and-selector tests

---------

Co-authored-by: Diego Pascual <[email protected]>
Co-authored-by: albertjcuac <[email protected]>
Co-authored-by: acondal <[email protected]>
Co-authored-by: Jose Antonio Cabañeros <[email protected]>
joseacabaneros and others added 11 commits September 16, 2024 11:37
BREAKING CHANGE: remove `change` event emission in favour of `update:modelValue` in `BaseSwitch` component.
* test: fix semantic queries test

* test: use queries preview composable

* fix e2e tests

* fix e2e tests

* test: rm unneeded reset in queries preview composable

* test: fix facets module tests

* test: fix semantics module tests

* test: wip

* test: preselected-filters in progress

* test: WIP stopped tests

* test: fix test sheets of filter components

* test: fix search-input test

* test: fix renderless-extra-params test

* test: fix clear-history-queries test sheet

* test: fix related-tags test sheets

* test: fix next-query test

* test: fix x-installer test sheet

* test: fix default-api test sheet

* test: fix test sheets related with vue-global-events third party dependency

* test: fix actions test sheet of related-tags module

* test: fix identifier-results test sheet

* test: fix results-list test sheet and forward slots in the component itself

* test: fix banners-list test sheet and forward slots in the component itself

* test: fix promoted-list test sheet and forward slots in the component itself

* test: fix next-queries test sheet

* test: fix selected-filters test sheet

* test: fix query-preview test sheet

* test: reactivate skipped test in history-query and clean up

* fix: PR comments

* test: fix search-input unit test

* test: fix next-queries-list test sheet

* test: fix minor issue with query-preview-list test sheet

* test: fix PR comments

---------

Co-authored-by: Diego Pascual <[email protected]>
Co-authored-by: acondal <[email protected]>
Co-authored-by: Laura Martinez Garcia <[email protected]>
Co-authored-by: albertjcuac <[email protected]>
@victorcg88 victorcg88 force-pushed the feat/add-types-for-related-prompts branch from d626e0b to fb4ae07 Compare October 21, 2024 13:47
@victorcg88 victorcg88 force-pushed the feat/add-related-prompts-adapter branch from f2a3671 to e3ae56a Compare October 21, 2024 13:53
@victorcg88 victorcg88 force-pushed the feat/add-related-prompts-adapter branch from e3ae56a to 0c59fc9 Compare October 21, 2024 14:07
@victorcg88 victorcg88 marked this pull request as ready for review October 21, 2024 14:22
@victorcg88 victorcg88 requested a review from a team as a code owner October 21, 2024 14:22
diegopf
diegopf previously approved these changes Oct 28, 2024
Base automatically changed from feat/add-types-for-related-prompts to main October 28, 2024 14:44
@victorcg88 victorcg88 dismissed diegopf’s stale review October 28, 2024 14:44

The base branch was changed.

@victorcg88 victorcg88 merged commit 8066983 into main Oct 28, 2024
4 checks passed
@victorcg88 victorcg88 deleted the feat/add-related-prompts-adapter branch October 28, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants