Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from vue-cli to vite #1350

Merged

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Nov 2, 2023

EMP-2527

Pull request template

Vue-cli is in maintenance mode and we should try to remove it from our dependencies in the x monorepo. The solution was migrate to vite.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-2527

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Try to run serve script and check if everything is working.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner November 2, 2023 13:07
@diegopf diegopf marked this pull request as draft November 2, 2023 13:11
@lauramargar lauramargar marked this pull request as ready for review November 3, 2023 07:35
@annacv
Copy link
Contributor

annacv commented Nov 6, 2023

Hi @lauramargar, @diegopf!
Here some doubts:

  • Checking some VueSchool docs I found we should configure eslint to add the environment es2022. Should we do this or this would collide with our ts config?
  • Regarding this doc, we should also remove vue-template-compiler, we are currently using it in x-tailwind and x-components packages. ---> I tried removing this package from devDependencies, served & built both x-tailwind & x-components packages and everything seems to be working fine. But I'm not sure if we should do so, as vue2.7 needs to use rollup-plugin-vue version 5.19and its is paired with vue-template-compiler.
  • Also noticed that while serving vite we get an error, which also arised in e2e tests: maybe we can check some discussion here & here to fix it, it could be something related to the need to create more alias to locate @empathyco/x-components:
    Captura de pantalla 2023-11-07 a les 18 04 33
  • Last I checked vue & vite versions that we are using in x-tailwind and maybe we could upgrade to the same ones (tried "vue": "~2.7.14", "vite": "^4.3.0" & seems to be working fine)

Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
All involved packages are being installed/built/served as expected.

Just one doubt: should we keep different package versions between peer & dev dependencies?

@diegopf diegopf changed the title chore(vite): migrate vue-cli to vite feat: migrate from vue-cli to vite Nov 13, 2023
@annacv annacv merged commit 52a3b6e into main Nov 13, 2023
4 checks passed
@annacv annacv deleted the feature/EMP-2527-remove-vue-cli-dependencies-in-x-monorepo branch November 13, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants