Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Doc of tracking add2cart event #1349

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Conversation

mariorey
Copy link
Contributor

@mariorey mariorey commented Nov 2, 2023

Added documentation about how to track add2cart event

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@mariorey mariorey requested review from a team as code owners November 2, 2023 13:03
@mariorey mariorey changed the title Update web-archetype-integration-guide.md Docs: Update web-archetype-integration-guide.md Nov 2, 2023
@mariorey mariorey changed the title Docs: Update web-archetype-integration-guide.md Docs: Doc of tracking add2cart event Nov 2, 2023
@herrardo
Copy link
Contributor

herrardo commented Nov 3, 2023

Do not merge, waiting for @mlcorton review. :)

Also:
* revised the content to make it clearer and more understandable.
* added link to sub-section from summary in Notes
@mlcorton
Copy link
Collaborator

mlcorton commented Nov 10, 2023

Hi there @mariorey! I've noticed that code snippets are breaking numbered lists. I've added a new commit to fix it (fyi, you need to indent code twice to solve it). Also, I've rewritten some content to make it clearer and match the current style and sentence structure. Tell me if I've misled any concept. :)
cc: @herrardo

…e-integration-guide.md

Co-authored-by: Gerardo Vázquez <[email protected]>
@herrardo herrardo merged commit 65509fd into main Nov 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants