-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Doc of tracking add2cart event #1349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariorey
changed the title
Update web-archetype-integration-guide.md
Docs: Update web-archetype-integration-guide.md
Nov 2, 2023
mariorey
changed the title
Docs: Update web-archetype-integration-guide.md
Docs: Doc of tracking add2cart event
Nov 2, 2023
herrardo
reviewed
Nov 2, 2023
packages/x-components/static-docs/build-search-ui/web-archetype-integration-guide.md
Outdated
Show resolved
Hide resolved
packages/x-components/static-docs/build-search-ui/web-archetype-integration-guide.md
Outdated
Show resolved
Hide resolved
packages/x-components/static-docs/build-search-ui/web-archetype-integration-guide.md
Outdated
Show resolved
Hide resolved
packages/x-components/static-docs/build-search-ui/web-archetype-integration-guide.md
Outdated
Show resolved
Hide resolved
packages/x-components/static-docs/build-search-ui/web-archetype-integration-guide.md
Outdated
Show resolved
Hide resolved
packages/x-components/static-docs/build-search-ui/web-archetype-integration-guide.md
Outdated
Show resolved
Hide resolved
packages/x-components/static-docs/build-search-ui/web-archetype-integration-guide.md
Outdated
Show resolved
Hide resolved
…e-integration-guide.md Co-authored-by: Gerardo Vázquez <[email protected]>
…e-integration-guide.md Co-authored-by: Gerardo Vázquez <[email protected]>
…e-integration-guide.md Co-authored-by: Gerardo Vázquez <[email protected]>
Do not merge, waiting for @mlcorton review. :) |
Also: * revised the content to make it clearer and more understandable. * added link to sub-section from summary in Notes
Hi there @mariorey! I've noticed that code snippets are breaking numbered lists. I've added a new commit to fix it (fyi, you need to indent code twice to solve it). Also, I've rewritten some content to make it clearer and match the current style and sentence structure. Tell me if I've misled any concept. :) |
herrardo
suggested changes
Nov 10, 2023
packages/x-components/static-docs/build-search-ui/web-archetype-integration-guide.md
Outdated
Show resolved
Hide resolved
…e-integration-guide.md Co-authored-by: Gerardo Vázquez <[email protected]>
mlcorton
approved these changes
Nov 10, 2023
herrardo
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation about how to track add2cart event
Pull request template
Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.
Motivation and context
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Tests performed according to testing guidelines:
Checklist: