feat(xcontrols): add actions #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ana Fernández Ostio <[email protected]>
EMP-2056 Co-Authored-By: Matías García Gimeno <[email protected]>
…eature/EMP-2056/create-store-module
- EMP-2056 * Added type to Store module * Remove getters from store * change State type (ExperienceControlsState) Co-Authored-By: Matías García Gimeno <[email protected]>
….com/empathyco/x into feature/EMP-2056/create-store-module
* EMP-2059 Co-Authored-By: Matías García Gimeno <[email protected]>
CachedaCodes
suggested changes
Sep 18, 2023
...components/src/x-modules/experience-controls/store/actions/fetch-and-save-controls.action.ts
Show resolved
Hide resolved
| any | ||
| >({ | ||
| fetch({ dispatch }, request) { | ||
| return dispatch('fetchControls', request); |
There was a problem hiding this comment.
When you have the full adapter here you won't just receive the controls but also the events to emit. This should be called fetchExperienceControlsResponse
...components/src/x-modules/experience-controls/store/actions/fetch-and-save-controls.action.ts
Outdated
Show resolved
Hide resolved
Comment on lines
8
to
9
| * @param request - To be done. | ||
| * @returns To be done. |
There was a problem hiding this comment.
Add a TODO to change with the adapter.
packages/x-components/src/x-modules/experience-controls/store/actions/fetch-controls.action.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/store/types.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/store/types.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/events.types.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/wiring.ts
Outdated
Show resolved
Hide resolved
CachedaCodes
suggested changes
Sep 19, 2023
packages/x-components/src/x-modules/experience-controls/store/types.ts
Outdated
Show resolved
Hide resolved
Comment on lines
13
to
17
| onSuccess({ commit }, controls) { | ||
| commit('setControls', controls); | ||
| commit('setEvents', {}); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This still doesn't take into account that the object returned by the success of the fetch will be similar to { controls, events }
Suggested change
| onSuccess({ commit }, controls) { | |
| commit('setControls', controls); | |
| commit('setEvents', {}); | |
| } | |
| }); | |
| onSuccess({ commit }, experienceControlsResponse) { | |
| commit('setControls', experienceControlsResponse.controls); | |
| commit('setEvents', experienceControlsResponse.events); | |
| } | |
| }); |
- EMP-2059 Co-Authored-By: Matías García Gimeno <[email protected]>
CachedaCodes
approved these changes
Sep 20, 2023
CachedaCodes
merged commit 6534e8f
into
feature/EMP-1944-create-config-module-xcontrols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
We have created some actions to obtain the experience controls service configuration, sending a request to it.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: