Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update node to v18 #1175

Merged
merged 5 commits into from
May 5, 2023
Merged

chore(deps): update node to v18 #1175

merged 5 commits into from
May 5, 2023

Conversation

ajperezbau
Copy link
Contributor

@ajperezbau ajperezbau marked this pull request as ready for review May 4, 2023 15:31
@ajperezbau ajperezbau requested a review from a team as a code owner May 4, 2023 15:31
@diegopf diegopf self-requested a review May 5, 2023 06:51
diegopf
diegopf approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@diegopf diegopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to make sure this appears as breaking change

@tiborux tiborux merged commit 14e64e1 into main May 5, 2023
@tiborux tiborux deleted the chore/EMP-274-update-nodejs-version-to-18 branch May 5, 2023 08:58
ajperezbau added a commit that referenced this pull request May 9, 2023
@ajperezbau
Revert "chore(deps): update node to v18 (#1175)"
5bb9331 
This reverts commit 14e64e1.
@ajperezbau ajperezbau mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegopf diegopf diegopf approved these changes

@tiborux tiborux tiborux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajperezbau @tiborux @diegopf