feat: migrate suggestions and currency components to vue 3 syntax #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CachedaCodes
suggested changes
Apr 26, 2023
packages/x-components/src/components/currency/base-currency.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/components/currency/base-currency.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/components/suggestions/base-suggestion.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/components/suggestions/base-suggestion.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/components/suggestions/base-suggestion.vue
Outdated
Show resolved
Hide resolved
Comment on lines
143
to
145
| const shouldHighlightCurated = computed<boolean>(() => { | ||
| return props.highlightCurated && !!props.suggestion.isCurated; | ||
| }); |
There was a problem hiding this comment.
Simplify to
Suggested change
| const shouldHighlightCurated = computed<boolean>(() => { | |
| return props.highlightCurated && !!props.suggestion.isCurated; | |
| }); | |
| const shouldHighlightCurated = computed<boolean>( | |
| () => props.highlightCurated && !!props.suggestion.isCurated | |
| ) |
packages/x-components/src/components/suggestions/base-suggestion.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/components/suggestions/__tests__/base-suggestion.spec.ts
Outdated
Show resolved
Hide resolved
CachedaCodes
suggested changes
Apr 28, 2023
| } | ||
| }, | ||
| setup(props) { | ||
| const root = ref<HTMLElement | null>(null); |
There was a problem hiding this comment.
Keep consistency with the decided name of the other PR (either root or el here)
CachedaCodes
approved these changes
May 1, 2023
diegopf
approved these changes
May 4, 2023
diegopf
deleted the
feature/EMP-529-migrate-suggestions-and-currency-folder-to-vue-3-syntax
branch
lauramargar
restored the
feature/EMP-529-migrate-suggestions-and-currency-folder-to-vue-3-syntax
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-529