Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show no result fallback in this order 1.semantics 2.partials 3.… #498

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

albertjcuac
Copy link
Contributor

@albertjcuac albertjcuac commented Sep 4, 2024

…recommendations

Pull request template

Motivation and context

The desired order for no result fallback is:

  1. Semantics
  2. Partials
  3. Recommendations

So we need to implement this logic in the archetype to avoid having to do it in every new client setup.

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

  1. search for a query with semantics
  2. in vue devtools remove semanticQueries
  3. If there are partials you should see them, if not you will see topclicked.
    'camiseta para mi boda mañana' has semantics but no partials
    'camiseta para mi cumpleaños' has semantics and partials

Tests performed according to testing guidelines:

@albertjcuac albertjcuac requested a review from a team as a code owner September 4, 2024 06:59
Copy link

github-actions bot commented Sep 4, 2024

Check PR 498 preview 👀

https://x.test.empathy.co/preview/498/index.html

@lauramargar lauramargar merged commit 258bd21 into main Sep 4, 2024
4 checks passed
@lauramargar lauramargar deleted the feature/show-semantics-results-before-partials branch September 4, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants