Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump packages versions and migrate to defineComponent #497

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Aug 14, 2024

Pull request template

Bump packages and migrate archetype components from class syntax to defineComponent syntax.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-4707

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Copy link

Check PR 497 preview 👀

https://x.test.empathy.co/preview/497/index.html

Copy link

Check PR 497 preview 👀

https://x.test.empathy.co/preview/497/index.html

Copy link

Check PR 497 preview 👀

https://x.test.empathy.co/preview/497/index.html

Copy link

Check PR 497 preview 👀

https://x.test.empathy.co/preview/497/index.html

Copy link

Check PR 497 preview 👀

https://x.test.empathy.co/preview/497/index.html

@lauramargar lauramargar marked this pull request as ready for review August 19, 2024 11:28
@lauramargar lauramargar requested a review from a team as a code owner August 19, 2024 11:28
albertjcuac
albertjcuac previously approved these changes Aug 19, 2024
Copy link

Check PR 497 preview 👀

https://x.test.empathy.co/preview/497/index.html

Copy link

Check PR 497 preview 👀

https://x.test.empathy.co/preview/497/index.html

@diegopf diegopf merged commit 3da651b into main Aug 21, 2024
4 checks passed
@diegopf diegopf deleted the feature/bump-packages-and-change-to-defineComponent branch August 21, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants