-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix backroom back from login context issue #492
fix: Fix backroom back from login context issue #492
Conversation
public/snippet-script.js
Outdated
audience: 'enterprise', | ||
playboardUrl: 'https://playboard-platform.staging.empathy.co/empathy', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specifically part of this fix but we also want to include the missing Playboard link in Backroom.
Check PR 492 preview 👀 |
Check PR 492 preview 👀 |
# Conflicts: # public/snippet-script.js
Check PR 492 preview 👀 |
Motivation and context
We have a bug in Backroom in which if after performing a query the user logs in, when returning to the Search layer Backroom context is not updated.
This is because the Backroom context was only updated with the
SearchRequestChanged
event but that event is not fired in the first search if loaded from the URL; adding a single line on theParamsLoadedFromUrl
fixes the issue.Type of change
What is the destination branch of this PR?
Main
Checklist: