Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix backroom back from login context issue #492

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

alvarodE
Copy link
Contributor

Motivation and context

We have a bug in Backroom in which if after performing a query the user logs in, when returning to the Search layer Backroom context is not updated.

This is because the Backroom context was only updated with the SearchRequestChangedevent but that event is not fired in the first search if loaded from the URL; adding a single line on the ParamsLoadedFromUrl fixes the issue.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@alvarodE alvarodE self-assigned this Jul 12, 2024
@alvarodE alvarodE requested a review from a team as a code owner July 12, 2024 08:49
@alvarodE alvarodE changed the title Fix/fix backroom back from login context issue fix: fix backroom back from login context issue Jul 12, 2024
@alvarodE alvarodE changed the title fix: fix backroom back from login context issue fix: Fix backroom back from login context issue Jul 12, 2024
audience: 'enterprise',
playboardUrl: 'https://playboard-platform.staging.empathy.co/empathy',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specifically part of this fix but we also want to include the missing Playboard link in Backroom.

Copy link

Check PR 492 preview 👀

https://x.test.empathy.co/preview/492/index.html

Copy link

Check PR 492 preview 👀

https://x.test.empathy.co/preview/492/index.html

Copy link

Check PR 492 preview 👀

https://x.test.empathy.co/preview/492/index.html

@alvarodE alvarodE merged commit 5e13903 into main Jul 17, 2024
4 checks passed
@alvarodE alvarodE deleted the fix/fix-backroom-back-from-login-context-issue branch July 17, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants