Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Send spellchecked query to Backroom #491

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

alvarodE
Copy link
Contributor

@alvarodE alvarodE commented Jul 1, 2024

Motivation and context

When available the spellchecked query must be sent to Backroom instead of the written one so tooling can be properly applied to the displayed results.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main

Checklist:

  • My code follows the style guidelines of this project.
  • [xx] I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@alvarodE alvarodE requested a review from diegopf July 1, 2024 14:20
@alvarodE alvarodE self-assigned this Jul 1, 2024
@alvarodE alvarodE requested a review from a team as a code owner July 1, 2024 14:20
src/App.vue Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 1, 2024

Check PR 491 preview 👀

https://x.test.empathy.co/preview/491/index.html

@alvarodE alvarodE changed the title feat: Send spellchecked query to Backroom fix: Send spellchecked query to Backroom Jul 1, 2024
Copy link

github-actions bot commented Jul 8, 2024

Check PR 491 preview 👀

https://x.test.empathy.co/preview/491/index.html

@diegopf diegopf merged commit fdb750e into main Jul 9, 2024
4 checks passed
@diegopf diegopf deleted the feat/send-spellchecked-query-to-backroom branch July 9, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants