fix: using .value in second part of columns conditional so columns.va…

[albertjcuac]

…lue is always array

Pull request template

Columns mapping expects a value coming from a computed property. To fix it in last PR, we had added a .value to the columns property, but the reactivity was not working. The real problem was that in columns computed property the second part of the conditional was returning a computed value, so we had a computed within another (columns.value was of type number[] | ComputedRef<number[]>). In the template, it was already accessing the value of the property. Now, by using .value to ensure that columns is always a ComputedRef<number[]>, everything seems to work fine.

Motivation and context

• Dependencies. If any, specify:
• Open issue. If applicable, link: EMP-3706

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that causes existing functionality to not work as expected)
• Change requires a documentation update

What is the destination branch of this PR?

• Main
• Other. Specify:

How has this been tested?

Column picker should appear and should be reactive.

Checklist:

• My code follows the style guidelines of this project.
• I have performed a self-review on my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.

[github-actions]

Check PR 462 preview 👀

https://x.test.empathy.co/preview/462/index.html

[annacv]

💯