Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track query when a result of a QP is clicked #452

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Feb 20, 2024

Pull request template

Update the Archetype project with the last version of x-components and with the approach of track query when a result of a QueryPreview is clicked.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-3538

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Open the devTools and go to the Network option. Click on a result of a QueryPreview and check if click, displayClick and query are sent.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner February 20, 2024 14:50
Copy link

Check PR 452 preview 👀

https://x.test.empathy.co/preview/452/index.html

Copy link

Check PR 452 preview 👀

https://x.test.empathy.co/preview/452/index.html

@CachedaCodes CachedaCodes merged commit 0fe9b90 into main Feb 21, 2024
4 checks passed
@CachedaCodes CachedaCodes deleted the feature/EMP-3538-update-x-archetype branch February 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants