feat: add click event and queryFeature in queriesPreview #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check PR 450 preview 👀 |
CachedaCodes
suggested changes
Feb 16, 2024
| @@ -3,6 +3,8 @@ | |||
| v-if="queriesPreviewInfo" | |||
| :debounceTimeMs="250" | |||
| :queriesPreviewInfo="queriesPreviewInfo" | |||
| :persistInCache="true" | |||
| :queryFeature="'customer'" | |||
There was a problem hiding this comment.
The component has a prop for the query feature and the default value is already 'customer'
Suggested change
| :queryFeature="'customer'" | |
| :queryFeature="queryFeature" |
|
Check PR 450 preview 👀 |
CachedaCodes
approved these changes
Feb 19, 2024
CachedaCodes
deleted the
feature/EMP-3537-track-display-and-click-events-and-send-the-correct-origin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Sends the correct origin in the query event and in the search request. That means sending in the QueryPreviewList the queryFeature 'customer' .
Also, we have to send the click and the display events. Take a look to the DisplayClickProvider component.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
originfield should appear.Networkin the devTools and when you click on a queryPreview result, click and displayClick should be sent.Checklist: