Change empathize layout for mobile devices #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check PR 445 preview 👀 |
|
Seems fine to me but maybe it could be good to add something to visually define the end of the empathize, like a border shadow. |
Hi @albertjcuac I have added a bottom border (same as the one used in myHistory aside), as shadows are not being used in archetype |
|
Check PR 445 preview 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-3460
Currently in the archetype for mobile devices, the query previews are shown in the pre-search state. However, once you focus on the search box there is no way to go back and see the query previews since the empathize is always taking the full height of the device.
Changes (only mobile):
x-layout-stackclass when there is no query, so query previews are still shown below the predictive layer & user can scroll to its content.x-mt-8in popular searches: this was sometimes a recurring change in setups, as the distance between history queries & popular searches block was fewer than between popular searches & top clicked carousel one.