Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update experience control endpoint #354

Merged

Conversation

herrardo
Copy link
Contributor

@herrardo herrardo commented Oct 31, 2023

EMP-2720

Remove explicit override of the experience control URL

Pull request template

The experience control endpoint has been deployed in Staging environment, so we no longer need the override.

https://api.staging.empathy.co/config/v1/public/configs?service=xcontrols&instance=empathy

Note: This will not work from PR preview, as the sudomain is x.test.empathy.co and the experience control ingress in Staging only accepts subdomain x.staging.empathy.co or localhost:8080

Run it locally to test.

Motivation and context

To have a standard implementation

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@herrardo herrardo requested a review from a team as a code owner October 31, 2023 15:37
@support-empathy
Copy link
Contributor

Check PR 354 preview 👀

https://x.test.empathy.co/preview/354/index.html

@CachedaCodes CachedaCodes merged commit 77b6f1e into main Nov 1, 2023
4 checks passed
@CachedaCodes CachedaCodes deleted the feat/EMP-27-20-update-x-perience-controls-endpoint branch November 1, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants