Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update x-components and fix base rating component #303

Merged

Conversation

lauramargar
Copy link
Contributor

Pull request template

Update x-components in the archetype adding a max-width to BaseRating component because if a x-flex class is applied the rating will not be filled correctly.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: 1588

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Add <BaseRating :value="3"></BaseRating> in result.vue file.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner July 31, 2023 07:18
@jenkins-empathy
Copy link

PR #303 preview deployed in https://x.test.empathy.co/preview/303/index.html

Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@annacv annacv merged commit e1e388f into main Jul 31, 2023
@annacv annacv deleted the bugfix/EMP-1588-deploy-in-archetype-base-rating-component branch July 31, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants