Issue#7 path refactoring #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit b8d1796 Merge: 5ad7394 ac671ed Author: brunocruz <[email protected]> Date: Wed Nov 23 17:48:44 2022 +0000 Merge pull request #6 from emotional-cities/s3b-compliant Enable data loading from AWS server commit ac671ed Author: bruno-f-cruz <[email protected]> Date: Wed Nov 23 17:15:56 2022 +0000 updated acceleromter IO to be s3f compliant commit 1487d50 Author: bruno-f-cruz <[email protected]> Date: Wed Nov 23 17:03:58 2022 +0000 Remove unused dependency commit f03170f Author: bruno-f-cruz <[email protected]> Date: Wed Nov 23 17:02:29 2022 +0000 updated empatica IO to be s3f compliant commit 61e7a60 Author: bruno-f-cruz <[email protected]> Date: Wed Nov 23 14:10:44 2022 +0000 updated microphone data to be s3f compliant commit 3477fd3 Author: bruno-f-cruz <[email protected]> Date: Wed Nov 23 14:10:09 2022 +0000 fix init commit 3baaca3 Author: bruno-f-cruz <[email protected]> Date: Wed Nov 23 13:51:20 2022 +0000 updated ubx to be s3f compliant commit cd42217 Author: bruno-f-cruz <[email protected]> Date: Wed Nov 23 11:14:27 2022 +0000 Enable harp stream loading from remote s3f commit b4889d8 Author: bruno-f-cruz <[email protected]> Date: Wed Nov 23 09:47:15 2022 +0000 Ensure the automatic conversion from input str add qol shortcut methods commit 8a3bb6e Author: bruno-f-cruz <[email protected]> Date: Tue Nov 22 14:47:24 2022 +0000 Initial sketch of Path class to handle s3fs remote commit 8ac20f6 Author: bruno-f-cruz <[email protected]> Date: Tue Nov 22 14:19:27 2022 +0000 Correct case-sensitive default paths commit 8ce683e Author: bruno-f-cruz <[email protected]> Date: Tue Nov 22 11:47:41 2022 +0000 Improve path generation and file io error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
Implements a more general logic to open files from AWS by always calling the "open" function. If the root folder is remote it will overload the open function from
s3fs. E.g.:All current streams were updated to implement this change.